chore: bump minimum PyTorch version from 2.3 to 2.4#1926
Open
Titus-von-Koeller wants to merge 3 commits intomainfrom
Open
chore: bump minimum PyTorch version from 2.3 to 2.4#1926Titus-von-Koeller wants to merge 3 commits intomainfrom
Titus-von-Koeller wants to merge 3 commits intomainfrom
Conversation
- Update dependency spec in pyproject.toml - Update docs (README, installation, quickstart) - Remove _IS_TORCH_GTE_24 compat shim in _ops.py (register_fake/register_kernel are always available in torch 2.4+) - Remove torch < 2.4 skipif guards in tests - Remove NumPy < 2 downgrade workaround for torch 2.3 on Windows - Update CI test matrices: 2.3.1 → 2.4.1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
fullgraph mode for torch.compile requires torch 2.8+, matching the existing guard in test_linear4bit_torch_compile. Previously masked by the torch < 2.4 skipif. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The failure on torch 2.4.1 is dynamo failing to trace MatmulLtState (UserDefinedObject `__bool__`), which is a different root cause than the Params4bit `.t()` issue that needs torch 2.8+ in the 4bit test. Torch 2.5+ has the dynamo UDO improvements needed for this to work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.toml, README, and docs_IS_TORCH_GTE_24compat shim in_ops.py—torch.library.register_fake/register_kernelare always available nowtorch < 2.4skipif guards in tests and theopcheckno-op fallbackNet change: -21 lines across 11 files.
Aligns with Transformers' minimum torch version ahead of the next release. Per discussion, bumping one version at a time (2.3 → 2.4) rather than jumping to 2.5.
Test plan
🤖 Generated with Claude Code