Conversation
Updated scaffold prompt to include AppFeatures registration and modified instructions for Add/Edit page. Signed-off-by: Yas Moradi <ysmoradi@outlook.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR updates the scaffolding prompt used by the AI agent to generate CRUD implementations. Changes extend agent metadata, add mandatory repository pattern research before scaffold generation, broaden add/edit UI guidance to cover both modal and page variants with integration steps, and refine exception-wrapping instruction scope to clarify it applies specifically to all event handlers. ChangesScaffolding Prompt Enhancements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/Templates/Boilerplate/Bit.Boilerplate/.github/prompts/scaffold.prompt.md (1)
38-38: ⚡ Quick winConsider adding a detailed guidance section for AppFeatures registration.
While AppFeatures registration is now listed as a requirement, there's no corresponding detailed section (like the ones for Entity, DTO, Mapper, API Controller, etc.) explaining the location, file structure, or specific requirements for this registration.
📝 Suggested addition after the Pages section
Always use `WrapHandled` for all event handlers. Exceptions are caught and handled by `ExceptionHandler`: ```razor <BitButton OnClick="WrapHandled(SaveData)" /> <BitTextField OnEnter="WrapHandled(async (args) => await Submit())" />
+### AppFeatures Registration
+- Location:src/Client/Boilerplate.Client.Core/
+- File:AppFeatures.cs
+- Requirements:
- Register the new feature and its pages in the feature management system
- Ensure proper navigation integration
- Add feature-specific permissions if required
</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In
@src/Templates/Boilerplate/Bit.Boilerplate/.github/prompts/scaffold.prompt.md
at line 38, Add a new detailed "AppFeatures Registration" section in
scaffold.prompt.md immediately after the Pages section describing what to change
in AppFeatures.cs (the feature registration file): specify that developers must
register the new feature and its pages in the feature-management class
AppFeatures.cs, show where to add navigation entries and hook up
feature-specific permissions, and include small examples/snippets for
registering the feature, wiring navigation, and declaring permissions so the
checklist mirrors other sections (Entity/DTO/Mapper/API Controller).</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.Nitpick comments:
In
@src/Templates/Boilerplate/Bit.Boilerplate/.github/prompts/scaffold.prompt.md:
- Line 38: Add a new detailed "AppFeatures Registration" section in
scaffold.prompt.md immediately after the Pages section describing what to change
in AppFeatures.cs (the feature registration file): specify that developers must
register the new feature and its pages in the feature-management class
AppFeatures.cs, show where to add navigation entries and hook up
feature-specific permissions, and include small examples/snippets for
registering the feature, wiring navigation, and declaring permissions so the
checklist mirrors other sections (Entity/DTO/Mapper/API Controller).</details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Repository UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `e79e1d08-8d6e-4b6b-a57d-5d4ddac0483b` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between dd28af586e3a6baa4c05602c03eb8c10322705be and 563080b68bf7bfaed9f203ac16a29d6ca1a9af77. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `src/Templates/Boilerplate/Bit.Boilerplate/.github/prompts/scaffold.prompt.md` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Closes #12373
Summary by CodeRabbit