Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a small “field builder” abstraction for dmfs task row mapping and extracts the task title mapping into a dedicated TitleBuilder, aligning behavior with existing calendar field builders.
Changes:
- Add
DmfsTaskFieldBuilderinterface for mapping individualTaskfields into an AndroidEntity. - Extract
Tasks.TITLEmapping intomapping/tasks/builder/TitleBuilder(blank/whitespace-only titles becomenullviatrimToNull()). - Add Robolectric unit tests covering the title mapping behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/DmfsTaskBuilder.kt | Switches title mapping to the new field-builder mechanism and applies built values via withValues(). |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/builder/DmfsTaskFieldBuilder.kt | Defines the task field builder interface and its contract (including explicit null handling). |
| lib/src/main/kotlin/at/bitfire/synctools/mapping/tasks/builder/TitleBuilder.kt | Implements Tasks.TITLE mapping using trimToNull() to normalize blank titles to null. |
| lib/src/test/kotlin/at/bitfire/synctools/mapping/tasks/builder/TitleBuilderTest.kt | Adds tests for missing/blank/text SUMMARY → TITLE mapping behavior. |
795a3f1 to
6193a0a
Compare
rfc2822
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
DmfsTaskFieldBuilderand extract title field mapping toTitleBuilder