Repeat Mpmc bounded buffer soak tests for fill-and-take scenarios#786
Merged
Repeat Mpmc bounded buffer soak tests for fill-and-take scenarios#786
Conversation
Agent-Logs-Url: https://github.com/bitfaster/BitFaster.Caching/sessions/b9ca3364-1ffb-4970-944d-6d63673254be Co-authored-by: bitfaster <12851828+bitfaster@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bitfaster
April 20, 2026 07:27
View session
bitfaster
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MPMC soak coverage was inconsistent:
WhenAddIsContendedBufferCanBeFilledalready ran 10 iterations, while the two concurrent fill-and-take scenarios ran once. This aligns those soak tests so the key buffer-fill contention paths execute with the same repetition.What changed
WhileBufferIsFilledItemsCanBeTakenfrom a single-run[Fact]to a repeated[Theory]WhileBufferIsFilledCountCanBeTakenfrom a single-run[Fact]to a repeated[Theory]SoakIterationsconstant so all three MPMC soak tests stay in syncResult
Example