Stop the brief panel running off the right edge - #6
Merged
Merged
Conversation
Sizing the panel at 100vw assumed it started at the left edge. It is anchored to a trigger near the right, so a viewport-wide panel hung off the screen: text wrapped at a width that was mostly off-screen, which read as no wrapping at all. Cap the width by --radix-popover-content-available-width, the room Radix measured from where it actually placed the panel, and let long unbroken strings break rather than widen it. Move every layout-critical property to inline styles. The plugin's Tailwind output is scoped to its own subtree and this content is portalled, so sizing should not depend on those classes reaching it. Cosmetics stay in className, where a miss is only cosmetic. The tests now assert the applied inline style. The previous ones checked that className contained w-[calc(100vw-1rem)] and passed while the panel rendered wrong — a class name being present says nothing about a rule reaching the element. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5, which made the panel scrollable but introduced a worse problem: the text stopped wrapping.
Sizing at
100vwassumed the panel starts at the left edge. It is anchored to a trigger near the right edge, so a viewport-wide panel hangs off the screen — its text wraps at a width that is mostly off-screen, which reads as no wrapping at all.--radix-popover-content-available-width: the room Radix measured from where it actually placed the panel, rather than a number I assumed.overflowWrap: anywhereso a long URL or branch name breaks instead of widening the panel past its cap.:where([data-bb-plugin=thread-briefs], …)) and this content is portalled, so sizing should not depend on those rules reaching it. Cosmetics stay inclassName, where a miss is only cosmetic.The tests were the real failure
The previous ones asserted
classNamecontainedw-[calc(100vw-1rem)]— and passed cheerfully while the panel rendered wrong. A class name being present says nothing about whether a rule reached the element. They now assert the applied inline style, which is the thing that actually determines layout.I checked the emitted CSS before changing anything, and the arbitrary-value rule was generated — so the class was never the problem, the assumed width was. Worth recording, because it would have been an easy wrong fix.
81 tests passing. Still verified in jsdom rather than on a phone, so this wants a real look on your device — it is the second time this panel has been wrong in a way jsdom happily reported as fine.
🤖 Generated with Claude Code