Skip to content

News346: correct waitNext() fee_threshold / MAX_MONEY description#2823

Open
Bartok9 wants to merge 1 commit into
bitcoinops:masterfrom
Bartok9:fix/news346-waitnext-max-money
Open

News346: correct waitNext() fee_threshold / MAX_MONEY description#2823
Bartok9 wants to merge 1 commit into
bitcoinops:masterfrom
Bartok9:fix/news346-waitnext-max-money

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 20, 2026

Copy link
Copy Markdown

Summary

  • Correct Newsletter Newsletters: add 85 (2020-02-19) #346's description of Bitcoin Core waitNext() / fee_threshold.
  • Clarifies that MAX_MONEY is the default fee threshold (disabling fee-based updates), not a level mempool fees must rise "above".

Motivation

Closes #2591.

The English Notable code and documentation changes entry for Bitcoin Core #31283 said waitNext() returns a new template when "mempool fees increase above the MAX_MONEY threshold." That misreads the API:

  • BlockWaitOptions::fee_threshold defaults to MAX_MONEY.
  • Per Core's own comment on that field, with the default the implementation skips the expensive fee comparison and only returns a new template when the chain tip changes (or on timeout / testnet min-difficulty conditions).
  • Callers that want fee-triggered updates set a lower fee_threshold; the wait then returns once total fees in a freshly assembled template are at least that many sats higher than the current template.

This update keeps the historical note but aligns it with the merged API. English-only in this PR; translated copies of #346 still carry the old wording and can follow separately.

Verification

  • Compared wording against Bitcoin Core PR #31283 (src/node/types.h BlockWaitOptions docs and the waitNext implementation path that treats fee_threshold < MAX_MONEY as the fee-check gate).
  • Cross-checked later Optech summary in Newsletter Newsletter-89:Translate into Japanese #380 (2025-12-19), which already describes waitNext() without the incorrect "above MAX_MONEY" claim.
  • Diff limited to one EN newsletter bullet; no YAML, matrix, or site layout changes.
  • Did not change FR/DE/ZH/CS/JA Newsletters: add 85 (2020-02-19) #346 translations in this PR (reviewers/translators can update those independently).

Notes for reviewers

  • Suggested follow-up (out of scope here): same wording fix in _posts/{fr,de,zh,cs,ja}/newsletters/2025-03-21-newsletter.md.

Agent-Owner: sera · Platform: hermes · Claim-TTL: 24h

MAX_MONEY is the default fee_threshold that disables fee-based template
updates, not a threshold that mempool fees must exceed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

News346: incorrect waitNext() description

1 participant