News346: correct waitNext() fee_threshold / MAX_MONEY description#2823
Open
Bartok9 wants to merge 1 commit into
Open
News346: correct waitNext() fee_threshold / MAX_MONEY description#2823Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
MAX_MONEY is the default fee_threshold that disables fee-based template updates, not a threshold that mempool fees must exceed.
Bartok9
force-pushed
the
fix/news346-waitnext-max-money
branch
from
July 20, 2026 12:29
5e990af to
9783bfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitNext()/fee_threshold.MAX_MONEYis the default fee threshold (disabling fee-based updates), not a level mempool fees must rise "above".Motivation
Closes #2591.
The English Notable code and documentation changes entry for Bitcoin Core #31283 said
waitNext()returns a new template when "mempool fees increase above theMAX_MONEYthreshold." That misreads the API:BlockWaitOptions::fee_thresholddefaults toMAX_MONEY.fee_threshold; the wait then returns once total fees in a freshly assembled template are at least that many sats higher than the current template.This update keeps the historical note but aligns it with the merged API. English-only in this PR; translated copies of #346 still carry the old wording and can follow separately.
Verification
src/node/types.hBlockWaitOptionsdocs and thewaitNextimplementation path that treatsfee_threshold < MAX_MONEYas the fee-check gate).waitNext()without the incorrect "above MAX_MONEY" claim.Notes for reviewers
_posts/{fr,de,zh,cs,ja}/newsletters/2025-03-21-newsletter.md.Agent-Owner:
sera· Platform: hermes · Claim-TTL: 24h