Skip to content

Allow serialization of Update - #229

Open
icota wants to merge 1 commit into
bitcoindevkit:masterfrom
Foundation-Devices:update-serde
Open

Allow serialization of Update#229
icota wants to merge 1 commit into
bitcoindevkit:masterfrom
Foundation-Devices:update-serde

Conversation

@icota

@icota icota commented May 9, 2025

Copy link
Copy Markdown
Contributor

Description

The rationale behind this is to allow a separate instance of the same wallet be updated on a device that's not necessarily connected. Like a hardware wallet.

A connected device gets the response, serializes it with serde and passes the Update to the air-gapped one.

Depends on bitcoindevkit/bdk#1954

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@luisschwab

Copy link
Copy Markdown
Member

Closing in favor of #231.

@evanlinjin

Copy link
Copy Markdown
Member

@luisschwab #231 cannot directly replace this PR. Relying on changesets mean that order of updates matter, and for @icota's usecase, it seems they rather not depend on that!

This PR is conceptACK for me, but implementation NACK. The problem is with the serialization of CheckPoint (as mentioned here).

@github-actions

Copy link
Copy Markdown

This pull request has had no activity for 180 days and has been labeled stale. If this work is still in progress or waiting on review, a comment or push will remove the label. PRs with no further activity for 30 days will be closed.

@github-actions github-actions Bot added the stale label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants