fix(chain,core): prevent serde from implicitly leaking std into no_std environments#2227
Open
EliteCoder18 wants to merge 1 commit into
Open
fix(chain,core): prevent serde from implicitly leaking std into no_std environments#2227EliteCoder18 wants to merge 1 commit into
EliteCoder18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix silent
serde/stdleak inbdk_coreandbdk_chainboth crates declared theirserdeoptional dependency withoutdefault features = false, causing serde's std feature to activate unconditionally even in no_std builds.bdk_core: addeddefault-features = false+serde?/stdin std feature.rcthe only two serde-derived types (BlockId,ConfirmationBlockTime) are pure scalars needing neitherserde/rcnorserde/alloc.bdk_chain: addeddefault-features = falseand explicitly enabledallocandrcdirectly on theserde dep+serde?/stdin std. Both are required becausetx_graph::ChangeSetholdsBTreeSet<Arc<Transaction>>andserdegatesArc<T>: Serializebehindall(feature = "rc", any(feature = "std", feature = "alloc")).This fix was identified while working on (bitcoindevkit/bdk_wallet#494).
Notes to the reviewers
The
allocandrcfeatures are placed on the serde dependency directly rather than behind a separate feature flag becausebdk_chainunconditionally requiresallocanyway.Changelog notice
Checklists
All Submissions: