Skip to content

cmake: Disable automatic C++20 module dependency scanning #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanofsky wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmake: Disable automatic C++20 module dependency scanning #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
set(CMAKE_CXX_STANDARD_REQUIRED YES)
endif()

# Disable automatic C++20 module dependency scanning.
# CMake >=3.28 tries to use `clang-scan-deps` by default, which may not
# be installed on all platforms. We don't use named modules, so turn this off.
set(CMAKE_CXX_SCAN_FOR_MODULES OFF)

@hebasto hebasto Aug 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with @purpleKarrot and other CMake developers that a project should avoid forcibly setting the CMAKE_* variables as much as possible.

As far as I understand this is a workaround for an upstream bug reported here.

I think the proper workaround is to modify the CI scripts without touching the project's CML files.

If "we don't use named modules", we shouldn't worry about them at all rather than explicitly disabling them.


include("cmake/compat_find.cmake")

find_package(Threads REQUIRED)
Expand Down
Loading