Fix SGB ATTR_BLK region rendering#79
Merged
Merged
Conversation
Properly manage the area border for the fill+outside and outside only cases
binji
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly manage the area border for the fill+outside and outside only cases with the ATTR_BLK command for Super GB mode.
Here's a comparison between the new version with these changes (left), Sameboy (middle) and the old version without the changes (right)
All other cases can be tested with this rom sgb-test.gb.zip by pressing A or B to rotate between the different combinations. Also tested with some commercial games and all seems work well.