Skip to content

fix renamed afterSettle event on upgrade-check.py - #4017

Closed
jorgecs10 wants to merge 1 commit into
bigskysoftware:four-devfrom
jorgecs10:patch-1
Closed

fix renamed afterSettle event on upgrade-check.py#4017
jorgecs10 wants to merge 1 commit into
bigskysoftware:four-devfrom
jorgecs10:patch-1

Conversation

@jorgecs10

Copy link
Copy Markdown

Fix bug on
Upgrade check tool

Description

upgrade check tool was instructing to rename htmx:afterSettle event to htmx:after:swap instead of htmx:after:settle

Checklist

  • [ ✓] I have read the contribution guidelines
  • [ ✓] I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • [ ✗] This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • [ ✗] I ran the test suite locally (npm run test) and verified that it succeeded

There was an error on the upgrade check tool, it was instructing to rename htmx:afterSettle event to htmx:after:swap
@MichaelWest22

Copy link
Copy Markdown
Collaborator

Thanks for the contribution! However, the fix isn't quite right here.

In htmx 2, htmx:afterSettle fired after the full swap-and-settle cycle completed. In htmx 4, the event model was redesigned with clearer before/after wrapping: the swap phase now has htmx:before:swap → htmx:before:settle → htmx:after:settle → htmx:after:swap. So htmx:after:swap in htmx 4 is the final event after everything (including settling) is done — making it the closest equivalent to the old htmx:afterSettle.

The upgrade-check tool's current mapping of htmx:afterSettle → htmx:after:swap is intentional and correct.

@jorgecs10

Copy link
Copy Markdown
Author

thanks for the explanation! I'll close this pull request then.

@jorgecs10 jorgecs10 closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants