fix renamed afterSettle event on upgrade-check.py - #4017
Closed
jorgecs10 wants to merge 1 commit into
Closed
Conversation
There was an error on the upgrade check tool, it was instructing to rename htmx:afterSettle event to htmx:after:swap
Collaborator
|
Thanks for the contribution! However, the fix isn't quite right here. In htmx 2, htmx:afterSettle fired after the full swap-and-settle cycle completed. In htmx 4, the event model was redesigned with clearer before/after wrapping: the swap phase now has htmx:before:swap → htmx:before:settle → htmx:after:settle → htmx:after:swap. So htmx:after:swap in htmx 4 is the final event after everything (including settling) is done — making it the closest equivalent to the old htmx:afterSettle. The upgrade-check tool's current mapping of htmx:afterSettle → htmx:after:swap is intentional and correct. |
Author
|
thanks for the explanation! I'll close this pull request then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug on
Upgrade check tool
Description
upgrade check tool was instructing to rename htmx:afterSettle event to htmx:after:swap instead of htmx:after:settle
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded