fix ajax so that target works but does not override source - #4008
Open
MichaelWest22 wants to merge 1 commit into
Open
fix ajax so that target works but does not override source#4008MichaelWest22 wants to merge 1 commit into
MichaelWest22 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix ajax() using target element as source when no source provided
When calling htmx.ajax() with only a target and no explicit source, the
target element was being used as the source for the request context. This
caused hx-target, hx-vals, hx-headers and other attributes on the target
to bleed into the request, and inputs inside the target to be collected
as form data on POST requests.
Fix: fall back to document.body as source when none is provided, and
resolve the explicit target after Object.assign so it always wins over
any hx-target read from the source element. Also guard document.body
against collecting descendant inputs on POST, since it is only ever a
fallback and should never vacuum up all inputs on the page.
Corresponding issue:
#4005
Testing
Added tests
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded