add migration rule to change preload to hx-preload in upgrade checker - #3994
Merged
1cg merged 1 commit intoAug 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe what changes you made, and why you feel they are necessary. Make sure to include
code examples, where applicable.
Htmx 2 docs recommend calling the extension with the
preloadattribute ( https://htmx.org/extensions/preload/),, "") while in htmx 4 you need to call the attributehx-preload. This PR adds a migration rule to the Upgrade Checker to warn the user of this change.Corresponding issue:
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
I had this issue in a codebase which uses HTMX, and ran
./upgrade-check.jsagainst my repo to make sure it found any usage ofpreloadinstead ofhx-preload.I ran
npm testlocally to make sure all 87 test files passed.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded