TRAC-238: Update PDP metadata images to use correct image url - #3174
Open
jordanarldt wants to merge 1 commit into
Open
TRAC-238: Update PDP metadata images to use correct image url#3174jordanarldt wants to merge 1 commit into
jordanarldt wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b12c5ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Bundle Size ReportComparing against baseline from No bundle size changes detected. |
Contributor
Unlighthouse Performance Comparison — VercelComparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores. Summary ScoreAggregate score across all categories as reported by Unlighthouse.
Category Scores
Core Web Vitals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
ProductPageMetadataQueryrequestedurlTemplate, which returns a URL containing a literal{:size}placeholder.<Image>expands that through the CDN loader at render time, butgenerateMetadatauses the value verbatim — soog:imagepointed at an unfetchable URL.url(width: 1200)returns a concrete URL instead. Height is omitted deliberately: the stencil resizer fits the image inside the given box rather than cropping, so asking for a social aspect ratio like1200x630would just return a smaller square image for a square product photo.Testing
View source on a PDP and confirm
og:imagecontains/stencil/1200w/rather than/stencil/{:size}/, and that the URL loads.Migration
In
core/app/[locale]/(default)/product/[slug]/page-data.ts, update thedefaultImageselection inProductPageMetadataQuery:defaultImage { altText - url: urlTemplate(lossy: true) + url(width: 1200, lossy: true) }Also included as a
## Migrationsection in the changeset.