Conversation
Merge develop into main: BBBSearch
fix: sync package-lock.json with package.json
fix: sync package-lock.json with package.json again
ci: add .nvmrc to centralize the node version definition; move sync-develop trigger to tag_and_release and fix tag ref
Build an ESM output alongside the existing UMD bundle and expose it through the package export map, with per-component subpaths (./Button, ./Modal, etc.) while preserving the legacy dist/components paths for CommonJS consumers. Add "sideEffects": ["**/*.css"] so bundlers can safely drop unused components, and a "node" condition so plain Node module resolution (SSR scripts, native test runners) falls back to the CJS build instead of failing on the ESM's extensionless imports. Extend the base tsconfig from tsconfig.esm.json to avoid duplicating compiler options between the two build targets.
- Bundle @tippyjs/react and tippy.js as direct dependencies, since they're required unconditionally by the internal Tooltip implementation, not something consumers choose to install. - Drop the duplicate @mui/icons-material entry from dependencies (already declared as a peer dependency). - Remove @mui/styles from peerDependencies; it's unused in src/. - Widen @mui/material and @mui/icons-material peer ranges to also accept ^7.0.0.
Modal was importing BBButton through the root barrel (../..), which drags the entire component tree into any bundle that includes Modal, defeating tree-shaking for consumers who only need this component.
fix: add tree-shakeable package exports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Manual merge since the sync workflow didn't run correctly.