Drop a dead import in the OPA evaluator spec - #511
Merged
Conversation
…or spec CodeQL caught this on PR #509 and it is a real finding in my own code, not noise: `GT-693` deleted the test that pinned the 27 unmapped policies, which was the only consumer of `CONTEXT_AWARE_VIOLATION_PREFIXES` in this spec. The import stayed behind. Removed rather than resolved-as-acceptable. The constant is still exported and still used in production as the fallback for a pre-GT-693 `policy.wasm`; what was dead is this file's reference to it. opa-evaluator spec 19/19. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claims no gap id. Deliberately: guard 50 rejected the first attempt at this because
its branch name and title both declared an id that the open promotion PR already
owns, and two open PRs claiming one gap is exactly the situation that cost a full
reconciliation session on 2026-07-30. The promotion PR owns it; this is a
follow-up.
What this is
CodeQL flagged an unused import in
opa-evaluator.spec.ts— a real finding in code I wrote earlier today, not noise.The test that pinned the 27 unmapped policies was deleted when attribution stopped
depending on that list, and it was the only consumer of
CONTEXT_AWARE_VIOLATION_PREFIXESin the spec. The import stayed behind.Removed rather than dismissed as acceptable. The constant is still exported and
still used in production, as the fallback path for a
policy.wasmcompiled beforethe provenance change; what was dead is this file's reference to it.
opa-evaluator spec 19/19.
🤖 Generated with Claude Code