Drop the dead import GT-693 left in the OPA evaluator spec - #510
Closed
beyondnetPeru wants to merge 1 commit into
Closed
Drop the dead import GT-693 left in the OPA evaluator spec#510beyondnetPeru wants to merge 1 commit into
beyondnetPeru wants to merge 1 commit into
Conversation
…or spec CodeQL caught this on PR #509 and it is a real finding in my own code, not noise: `GT-693` deleted the test that pinned the 27 unmapped policies, which was the only consumer of `CONTEXT_AWARE_VIOLATION_PREFIXES` in this spec. The import stayed behind. Removed rather than resolved-as-acceptable. The constant is still exported and still used in production as the fallback for a pre-GT-693 `policy.wasm`; what was dead is this file's reference to it. opa-evaluator spec 19/19. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
Contributor
Author
|
Superseded: this PR's branch name and title both declared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to
GT-693. No gap id is claimed or advanced here.CodeQL flagged this on #509
and it is a real finding in my own code:
GT-693deleted the test that pinned the27 unmapped policies — the only consumer of
CONTEXT_AWARE_VIOLATION_PREFIXESinthat spec — and the import stayed behind.
Removed rather than dismissed. The constant is still exported and still used in
production as the fallback path for a
policy.wasmcompiled beforeGT-693; whatwas dead is this file's reference to it.
opa-evaluator spec 19/19.
🤖 Generated with Claude Code