Fix getRequestStartTime for Octane workers#43
Open
m0nclous wants to merge 1 commit intobeyondcode:masterfrom
Open
Fix getRequestStartTime for Octane workers#43m0nclous wants to merge 1 commit intobeyondcode:masterfrom
m0nclous wants to merge 1 commit intobeyondcode:masterfrom
Conversation
Sergey27-dev
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix defining
$this->startviagetRequestStartTime()for Laravel Octane workers#37
Problem
Under Laravel Octane (Swoole/RoadRunner/FrankenPHP), worker processes are persistent and handle multiple requests during their lifetime. The previous implementation relied on
$_SERVER['REQUEST_TIME_FLOAT']and theLARAVEL_STARTconstant, both of which are set once at worker initialization and never updated between requests.This caused
$this->startto always reflect the start time of the first request handled by the worker, making all subsequent server timing measurements incorrect.Solution
Use
request()->server('REQUEST_TIME_FLOAT')instead, which reads from the current request context that Octane properly resets on each request.The
LARAVEL_STARTconstant is still used as a fallback for non-Octane environments where$_SERVERand constants behave as expected.Changes
getRequestStartTime()now checks forLARAVEL_OCTANEin the request context to determine the runtime environment$_SERVERsuperglobal withrequest()->server()for Octane compatibility