Prevent floating number precision issue#418
Open
puck wants to merge 1 commit into
Open
Conversation
05a7d93 to
a11b7e8
Compare
Some test runs would cause runid to end up with a slightly differing values in the database which caused the tests to fail. An example of a failing test is when $runid was observed to be 153.425536363056, but in the database it is stored as '153.42553636305601'. This caused the Attribute to not be found causing some of the tests to fail. I see no need for a long fraction to be used, so truncate it.
a11b7e8 to
2fd5484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test runs would cause runid to end up with a slightly differing values which caused the tests to fail.
An example of failing test is when $runid was observed to be 153.425536363056, but in the database it is stored as '153.42553636305601'. This caused the Attribute to not be found causing some of the tests to fail.
I see no need for a long fraction to be used, so truncate it.
I haven't seen this issue on the Intel i7 I normally test on, but was reproducible about 50% of the time on an AMD EPYC that a fellow Debian Developer runs package tests on.
I added debugging to lib/RT/Record.pm to see what was happening and got this:
Check database file: