Fix macOS local build crash when PYFA_VERSION is unset#1
Closed
benkwokcy wants to merge 2 commits into
Closed
Conversation
The macOS spec read the bundle version from os.getenv('PYFA_VERSION')
in three places with no fallback. Outside CI that env var is unset, so
the value is None and plistlib raises "unsupported type: NoneType" at
the BUNDLE step, breaking local builds.
Fall back to the git-describe label the spec already computes, so local
builds succeed while CI behavior (env var wins) is unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
eve.db is built by db_update.py (~99 MB) and was not ignored, making it easy to commit by accident. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building the macOS app from a local checkout crashes at the BUNDLE step:
dist_assets/mac/pyfa.specreads the bundle version fromos.getenv('PYFA_VERSION')in three places. That env var is only set in CI, so outside CI the value isNone, andplistlibcannot serializeNoneintoInfo.plist. The build fails right after COLLECT succeeds.Fix
Fall back to the
git describe --tagslabel the spec already computes at the top (and writes to.version). CI is unchanged —PYFA_VERSIONstill wins when set; local builds now succeed and get the git-describe version in the plist instead of crashing.Also ignore the generated
eve.db(~99 MB, built bydb_update.py), which was untracked and easy to commit by accident.Testing
PyInstaller -y --clean dist_assets/mac/pyfa.specwithPYFA_VERSIONset → builds (unchanged behavior).PYFA_VERSIONunset → previously crashed, now builds;CFBundleShortVersionString=v2.66.3-8-g0469e9733.pyfa.applaunches.Built on macOS arm64 (M1), Python 3.11, PyInstaller 6.2.0.
🤖 Generated with Claude Code