Preserve list structure when setting a list index - #199
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Setting a value through an integer subview overlaid a dict of
{index: value} on top of the parent, so a list source was replaced by an
integer-keyed mapping: config["stages"][0]["name"].set(x) turned the
whole "stages" list into {0: {"name": x}}.
Subview.set now detects an integer key whose parent resolves to a list
and rebuilds that list with only the target index replaced.
ConfigView.__setitem__ routes through the subview so item assignment
takes the same path.
Adds regression tests for both the flat and nested list cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
Subview.setoverlaid{key: value}on the parent, so setting through an integer index replaced the containing list with an integer-keyed mapping:config["stages"][0]["name"].set(x)turnedstagesinto{0: {"name": x}}. It now rebuilds the list with only that index replaced when the parent resolves to a list, and__setitem__routes through the subview so item assignment takes the same path.Regression tests added for the flat and nested cases; they fail on the previous behaviour. Full suite: 295 passed, 3 skipped.