Add Embedded Art support to `fetchart` plugin by overhacked · Pull Request #6829 · beetbox/beets

overhacked · 2026-07-12T20:32:10Z

Description

Add embedded source to extract embedded art from files. Add skip_embedded option to detect embedded art and skip fetching from other sources (if extracting isn't the desired end state).

If skip_embedded=yes, then files with embedded art are considered "done" and skipped by FetchArt. If the embedded source is enabled, then embedded artwork is always extracted. The two settings are independent of each other.

Fixes #1130.

To Do

Documentation.
Changelog.
Tests.

codecov · 2026-07-12T20:38:00Z

Codecov Report

❌ Patch coverage is 60.97561% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.66%. Comparing base (efc8970) to head (f63691c).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
beetsplug/fetchart.py	60.97%	11 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6829      +/-   ##
==========================================
- Coverage   75.68%   75.66%   -0.02%     
==========================================
  Files         163      163              
  Lines       21423    21459      +36     
  Branches     3387     3393       +6     
==========================================
+ Hits        16213    16238      +25     
- Misses       4410     4419       +9     
- Partials      800      802       +2

Files with missing lines	Coverage Δ
beetsplug/fetchart.py	`73.41% <60.97%> (-0.47%)`	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

overhacked · 2026-07-13T00:15:12Z

Taking this to draft to do a little work to improve the test coverage.

overhacked · 2026-07-15T13:30:24Z

@snejus, this is ready whenever you have time to take a look. There are some test coverage places I'd like to address, but when investigating I found that more test harness refactoring around when plugins read their configuration (e.g. @cached_property and PluginMixin.preload_plugin vs .configure_plugin()) would be necessary to get more coverage; also, the coverage gaps--while technically part of this PR's diff--already existed in the fetchart CLI test suite, so I'd be adding tests that don't test the Embedded source directly.

semohr

Thanks! Looks mostly good from my side 👍

semohr · 2026-07-29T08:52:43Z

        matches = []
        # can there be more than one releasegroupid per response?
-        for mbid, art in data.get("albums", {}).items():
+        for mbid, images in data.get("albums", {}).items():


Why was this renamed from art to images ?

_utils.art is now imported, so this line triggers a variable-shadowing lint. I changed the loop variable name so as not to add to the number of linter warnings.

snejus · 2026-07-29T21:27:15Z

+        for album in self.albums:
+            candidate = next(source.get(album, settings, None))


Do we need to check every album? Would it be enough to get the first candidate instead?

This does get the first candidate for each album (next()) created in setup_beets(), but loops over all the albums to test embedded art extraction in all of the media formats. I was going to use pytest parameterization when I first wrote this, but it ended up being less complex code to just create mock albums for each format, IIRC.

snejus · 2026-07-29T21:29:12Z

+    For test safety to ensure no changes cause tests to make
+    real, unmocked requests for cover art.
+    """
+    return


Do we actually want to make real requests here?

Suggested change

return

yield

There is no setup or teardown in this fixture, so yield is unnecessary, and it triggers the lint No teardown in fixture... use 'return' instead of 'yield'.

We don't want to make make real requests in test_fetchart.py, because all its tests are of the import and fetchart CLI logic of the plugin, so we want to fail a test if we've accidentally failed to mock something. The real art fetching tests are in test_art.py.

Add `embedded` source to extract embedded art from files. Add `skip_embedded` option to detect embedded art and skip fetching from other sources (if extracting isn't the desired end state). If `skip_embedded=yes`, then files with embedded art are considered "done" and skipped by FetchArt. If the `embedded` source is enabled, then embedded artwork is always extracted. The two settings are independent of each other. Fix variable shadowing lint due to added import of `_utils.art`. Signed-off-by: Ross Williams <ross@ross-williams.net>

Add unit tests for Embedded source of FetchArt plugin. Add integration tests for FetchArt plugin's handling of files with embedded artwork. Signed-off-by: Ross Williams <ross@ross-williams.net>

Signed-off-by: Ross Williams <ross@ross-williams.net>

overhacked requested a review from a team as a code owner July 12, 2026 20:32

github-actions Bot added the fetchart fetchart plugin label Jul 12, 2026

overhacked marked this pull request as draft July 13, 2026 00:14

overhacked force-pushed the overhacked/fetchart_embedded branch 2 times, most recently from 18cd2e7 to aac06ee Compare July 15, 2026 13:25

overhacked marked this pull request as ready for review July 15, 2026 13:25

semohr reviewed Jul 29, 2026

View reviewed changes

snejus requested changes Jul 29, 2026

View reviewed changes

snejus reviewed Jul 29, 2026

View reviewed changes

overhacked force-pushed the overhacked/fetchart_embedded branch 2 times, most recently from 1bfaee4 to 85d67e2 Compare August 1, 2026 01:39

Serene-Arc requested changes Aug 1, 2026

View reviewed changes

Comment thread beetsplug/fetchart.py Outdated

overhacked added 6 commits August 1, 2026 14:53

test: FetchArt plugin embedded art

1b5f35e

Add unit tests for Embedded source of FetchArt plugin. Add integration tests for FetchArt plugin's handling of files with embedded artwork. Signed-off-by: Ross Williams <ross@ross-williams.net>

Changelog entry for FetchArt embedded features

b1a832a

Signed-off-by: Ross Williams <ross@ross-williams.net>

Add return type for album_has_art

7d86eaf

Signed-off-by: Ross Williams <ross@ross-williams.net>

docs: add link directly to embedded-art-source

7a908db

Signed-off-by: Ross Williams <ross@ross-williams.net>

Fix lint in embedded plugin

fac8012

Signed-off-by: Ross Williams <ross@ross-williams.net>

overhacked force-pushed the overhacked/fetchart_embedded branch from cab47f9 to fac8012 Compare August 1, 2026 18:55

Fix tempfile cleanup logic in fetchart.Embedded.get

f63691c

		for album in self.albums:
		candidate = next(source.get(album, settings, None))

Uh oh!

Conversation

overhacked commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

To Do

Uh oh!

codecov Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

overhacked commented Jul 13, 2026

Uh oh!

overhacked commented Jul 15, 2026

Uh oh!

semohr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

semohr Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

overhacked Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

snejus Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

overhacked Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

snejus Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

overhacked Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

overhacked commented Jul 12, 2026 •

edited

Loading

codecov Bot commented Jul 12, 2026 •

edited

Loading