deps: clear open Dependabot alerts#26
Merged
Merged
Conversation
Bump direct deps and add yarn resolutions for vulnerable transitive
packages so the lockfile no longer carries ranges flagged by
Dependabot.
Direct bumps:
- testcontainers ^10 -> ^11 (lib + postgres-server) brings undici 7.x
in place of 5.29, fixing four undici advisories.
- express ^4.18.2 -> ^4.22.1 (server) relaxes the path-to-regexp pin
to ~0.1.12 so the resolution to 0.1.13 applies cleanly.
- @typescript-eslint/{eslint-plugin,parser} ^6.21.0 -> ^7.18.0 to drop
typescript-estree's exact pin on the vulnerable minimatch 9.0.3.
Root-level resolutions:
- follow-redirects ^1.16.0 (mongodb-memory-server transitively)
- qs ^6.14.2
- diff ^4.0.4 (ts-node transitively)
- lodash ^4.18.1 (archiver transitively)
- path-to-regexp 0.1.13 (express transitively)
- minimatch — pinned per parent path so each major line collapses to
a non-vulnerable version (3.1.5 / 5.1.9 / 9.0.9). A global override
doesn't work here because some old consumers (test-exclude via
babel-plugin-istanbul) still call require('minimatch') as a function,
which only works on the v3 line.
Verified locally: yarn typecheck, all four packages' unit tests, and
yarn lint all run with the same 147 pre-existing lint issues that exist
on main and no new ones.
Both Node 18 (EOL Apr 2025) and Node 20 (maintenance only) lag behind the dependency tree we now resolve to. Specifically, undici 7 (pulled in by testcontainers 11) needs Node >= 20.18.1, and Node 18 errors out on install. Move the matrix to currently-supported LTS lines (22, 24) and update the publish workflow to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears all 18 open Dependabot alerts by bumping a few direct deps and adding a small
resolutionsblock for the rest of the vulnerable transitive packages.Direct bumps
testcontainers^10 → ^11 inlib+postgres-server. Bringsundici7.x in place of 5.29, fixing four undici advisories.express^4.18.2 → ^4.22.1 inserver. Relaxes thepath-to-regexppin to~0.1.12so the resolution to0.1.13applies cleanly.@typescript-eslint/{eslint-plugin,parser}^6.21.0 → ^7.18.0. Dropstypescript-estree's exact pin on the vulnerableminimatch@9.0.3— v7 uses^9.0.4, which the resolution then steers to9.0.9.Root resolutions
follow-redirects^1.16.0 (transitive via mongodb-memory-server)qs^6.14.2 (transitive via express/body-parser)diff^4.0.4 (transitive via ts-node)lodash^4.18.1 (transitive via archiver)path-to-regexp0.1.13(transitive via express)minimatch, pinned per parent so each major line collapses to a non-vulnerable version (3.1.5 / 5.1.9 / 9.0.9).Why per-parent minimatch resolutions
A single global
minimatchresolution to ^9 breaks the test runner.babel-plugin-istanbul(used by jest coverage) goes throughtest-exclude→glob@7→require('minimatch')(), and v9 dropped the default function export, so calling it as a function throwsminimatch is not a function. The per-parent resolutions keep the v3 callers on the latest 3.x (3.1.5) and the v5/v9 callers on their respective patched lines.Verified locally
yarn typecheckyarn workspace @queryleaf/lib test:unityarn workspace @queryleaf/cli testyarn workspace @queryleaf/server test:unityarn workspace @queryleaf/postgres-server test:unit(incl. server.test.ts which is the one that broke under the global resolution)yarn lintruns with the same 147 pre-existing lint issues that exist on main — no new ones from the typescript-eslint v7 bump.Test plan