feat(ops): conditional vanity route deployment - #2801
Open
DerekRoberts wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for an optional “vanity URL” OpenShift Route for the frontend that is only deployed when a vanity_url input is provided, enabling TLS material to be injected from GitHub Secrets while leaving the default route unchanged.
Changes:
- Introduces a new OpenShift Template to create a secondary frontend Route with edge TLS using provided certificate material.
- Extends the reusable GitHub Actions deploy workflow to accept a
vanity_urlinput plus TLS-related secrets. - Conditionally deploys the vanity route during the frontend matrix deployment when
vanity_urlis non-empty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
frontend/openshift.vanity-route.yml |
New OpenShift template for a secondary (vanity) frontend Route with injected TLS fields. |
.github/workflows/reusable-deploy.yml |
Adds inputs/secrets and a conditional deployment step to apply the vanity route template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DerekRoberts
force-pushed
the
feat/vanity-route
branch
from
August 6, 2026 20:44
ebb93cd to
20c8d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces an optional Vanity URL OpenShift route that only deploys if
vanity_urlis populated. It leaves the default route untouched, allowing consumers to safely pilot GitHub Secrets-driven TLS.New Features & Safety Rails
openshift.vanity-route.ymltemplate, ensuring primary PROD routes are insulated from vanity config errors.opensslin the pipeline to mathematically validate that the private key matches the certificate before talking to OpenShift. Prevents garbage secrets from breaking live routes.scripts/validate_tls_pair.shto allow developers to pre-verify certificates locally.README.md.Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: