32911 - Add validation for foreign business legal name length#4395
Open
mruff-aeq wants to merge 1 commit into
Open
32911 - Add validation for foreign business legal name length#4395mruff-aeq wants to merge 1 commit into
mruff-aeq wants to merge 1 commit into
Conversation
mruff-aeq
force-pushed
the
32911_Add_Foreign_Business_Legal_Name_Length_Validation
branch
from
86c8986 to
32e35c4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32911 : /bcgov/entity#32911
Description of changes:
We discovered that the backend wasn’t validating the length of a foreign amalgamating business’s legalName. The frontend correctly blocked names shorter than 3 characters or longer than 150, but the backend didn’t — so invalid values could still slip through and get saved.
The backend now enforces the same 3–150 character limit. If the name is outside that range, it returns a 400 error with the message “Length of foreign business legal name must be from 3 to 150 characters.”
Example:
when making a POST to url
/api/v2/businesses/<T-id>/filings?only_validate=true"legalName": "AA"in payload throws 400 error “Length of foreign business legal name must be from 3 to 150 characters.”"legalName": "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA"in payload throws 400 error “Length of foreign business legal name must be from 3 to 150 characters.”By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).