32907: require at least one share class on regular amalgamation appli…#4392
Merged
mruff-aeq merged 1 commit intoMay 14, 2026
Merged
Conversation
|
meawong
reviewed
May 14, 2026
| if filing_type == CoreFiling.FilingTypes.INCORPORATIONAPPLICATION.value and len(share_classes) == 0: | ||
| # For incorporation and amalgamation applications, at least one share class is required, for Alteration can not include if not changing | ||
| if filing_type in (CoreFiling.FilingTypes.INCORPORATIONAPPLICATION.value, | ||
| CoreFiling.FilingTypes.AMALGAMATIONAPPLICATION.value) and len(share_classes) == 0: |
Collaborator
There was a problem hiding this comment.
Nice, I see we have already filtered to validate share structure for regular amalgamation type only: https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/services/filings/validations/amalgamation_application.py#L86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32907 : /bcgov/entity#32907
Description of changes:
Posting a regular amalgamation application via POST
http://127.0.0.1:5000/api/v2/businesses/T0nRimgoiH/filings?only_validate=truewith the payload adjusted to"shareStructure": { "shareClasses": [] }previously succeeded. After this change, the same request returns a 400 containing the error"A company must have at least one Class of Shares.", now aligning with front end logic.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).