32806 - Business API - update LEGAL_API_BASE_URL to use gw url instead of internal api url#4389
Merged
Merged
Conversation
…ernal api url Signed-off-by: Kial Jinnah <kialj876@gmail.com>
kialj876
commented
May 13, 2026
| BUSINESS_API_GW_URL="op://API/$APP_ENV/business-api/BUSINESS_API_GW_URL" | ||
| BUSINESS_API_VERSION_2="op://API/$APP_ENV/business-api/BUSINESS_API_VERSION_2" | ||
| LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL" | ||
| LEGAL_API_VERSION_2="op://API/$APP_ENV/legal-api/LEGAL_API_VERSION_2" |
Collaborator
There was a problem hiding this comment.
(any cleanup for SRE? Or just not needed in this proj, or already gone from secret storage?)
Collaborator
Author
There was a problem hiding this comment.
I think there's other projects still using this at the moment (this was the original 1pass key so I think several other projects still use it - i.e. search). I'm thinking we just let SRE manage the 1pass cleanup when they are ready
kialj876
commented
May 13, 2026
| LEGAL_API_URL="op://API/$APP_ENV/legal-api/LEGAL_API_URL" | ||
| LEGAL_API_VERSION_2="op://API/$APP_ENV/legal-api/LEGAL_API_VERSION_2" | ||
| NAICS_API_URL="op://API/$APP_ENV/naics-api/NAICS_API_URL" | ||
| NAICS_API_VERSION="op://API/$APP_ENV/naics-api/NAICS_API_VERSION" |
Collaborator
Author
There was a problem hiding this comment.
was already not being used (uses BUSINESS_API_URL/VERSION_2)
|
meawong
approved these changes
May 13, 2026
kialj876
changed the title
loneil
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32806
Description of changes:
env
business response
filing response
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).