Decouple planning→execution flip across task lifecycle commands#50
Merged
Conversation
plan-task now validates and hands off without flipping phase; execute-task is the sole command that flips planning→execution; work-on/work-on-task/ work-on-goal stop auto-chaining and print an explicit plan→execute→complete next-step signal. Fixes execute-task running as a silent no-op.
There was a problem hiding this comment.
{
"verdict": "approve",
"summary": "Pure slash-command documentation refactor — all 7 Plan concerns verified correct in diff. plan-task no longer flips phase (now hands off to execute-task), execute-task is the sole planning→execution gate, work-on-task/work-on-goal/work-on all print next-step signals instead of auto-chaining, and task-writing.md phase table reflects the new single-responsibility model accurately. No Go code changed; no test coverage gaps introduced.",
"comments": [],
"concerns_addressed": [
"correctness: plan-task no longer flips phase — Step 7 changed to 'hand off to execute-task (no phase flip)', removed `vault-cli task set phase execution`",
"correctness: execute-task is now the sole gate for planning→execution flip — lifecycle section updated to 'the sole gate'",
"correctness: work-on-task Phase 5 changed from auto-sharpen+auto-gate to next-step signal — prints plan/execute/complete commands without invoking them",
"correctness: work-on-goal has new Phase 3 'Signal next steps' — mirrors work-on-task Phase 5 correctly, no auto-chain",
"correctness: work-on.md Phase 3 updated to 'Next-step signal' — both task and goal routes print signal without auto-invoke",
"correctness: docs/task-writing.md phase table updated — plan-task 'hands off to /execute-task — never flips phase', execute-task is 'the sole command that flips planning→execution'",
"tests: no test files changed — correctly reflects that existing tests cover unchanged behavior (this is a docs-only change to slash command definitions)"
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the task lifecycle four deliberate, non-overlapping steps:
work-on → plan-task → execute-task → complete-task.Why
Previously two commands flipped the same
planning → executiontransition:plan-taskflipped it itself, andwork-on*auto-chainedexecute-task. In the auto-chainplan-taskalways won the flip, soexecute-taskran as a silent no-op and never acted as the real gate.Changes
planning, signals/execute-task.planning → execution(unchanged gate logic).plan-task/execute-task; each prints an explicit plan → execute → complete next-step signal.docs/task-writing.mdphase table +README.md.work-on-task/work-on-goal kept in parallel with work-on (canonical) per current direction.
Verify
make precommitgreen (tests, lint, version alignment, CHANGELOG structure).