Skip to content

Fix format string handling for collection_subject.contains_none_of. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Aug 5, 2026
+19 −1
Merged

Fix format string handling for collection_subject.contains_none_of. #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/private/collection_subject.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,9 @@ def _collection_subject_contains_none_of(self, values):
self: implicitly added
values: ([`collection`]) values of which none of are allowed to exist.
"""
values = to_list(values)
if self.format:
values = self.meta.format_str(values)
values = [self.meta.format_str(v) for v in values]
check_contains_none_of(
collection = self.actual,
none_of = values,
Expand Down
17 changes: 17 additions & 0 deletions tests/truth_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,23 @@ def _action_subject_test(env, target):
msg = "check argv success",
)

subject.argv().contains_none_of([
"arg1",
"arg3",
"{bindir}/{package}/input.gen.txt",
])
_assert_failure(
fake_env,
[
"expected not to contain any of",
"but 2 found",
"arg1",
"input.gen.txt",
],
env = env,
msg = "check contains_none_of failure",
)

subject.contains_flag_values([
("--missingflag", "whatever"),
("--arg1flag", "wrongvalue"),
Expand Down