Disable path mapping for Rust linking actions - #4193
Open
tamird wants to merge 1 commit into
Open
Conversation
tamird
force-pushed
the
fix/rustc-linker-path-mapping
branch
from
August 1, 2026 10:57
e21cb00 to
60231db
Compare
tamird
force-pushed
the
fix/rustc-linker-path-mapping
branch
from
August 1, 2026 11:11
80faf8d to
f475019
Compare
UebelAndre
requested changes
Aug 1, 2026
UebelAndre
left a comment
UebelAndre
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I had just one question
tamird
marked this pull request as draft
August 1, 2026 13:27
Contributor
Author
|
I'm not entirely happy with this; marking as draft for now. |
tamird
force-pushed
the
fix/rustc-linker-path-mapping
branch
from
August 1, 2026 14:42
f475019 to
e99792b
Compare
tamird
changed the title
tamird
marked this pull request as ready for review
August 1, 2026 14:43
tamird
force-pushed
the
fix/rustc-linker-path-mapping
branch
8 times, most recently
from
August 1, 2026 16:23
d6a5e4c to
7cd5916
Compare
C/C++ toolchain APIs flatten selected linker paths and feature-expanded arguments into strings. With path mapping enabled, generated linker, library-search, resource, and CRT paths retain their real configuration while the execution sandbox uses mapped paths, causing native links to fail. Do not advertise path mapping for actions that link native artifacts, including WebAssembly native dependencies. Retain mapping for Rust libraries, metadata, and ordinary documentation. Represent generated-file paths in compiler environment files as substitution tokens. Resolve each token from its File in the consuming action so shared environment files remain valid for both mapped and unmapped layouts. Assisted-by: Codex
tamird
force-pushed
the
fix/rustc-linker-path-mapping
branch
from
August 1, 2026 16:52
7cd5916 to
0435525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C/C++ toolchain APIs flatten selected linker paths and feature-expanded
arguments into strings. With path mapping enabled, generated linker,
library-search, resource, and CRT paths retain their real configuration
while the execution sandbox uses mapped paths, causing native links to
fail.
Do not advertise path mapping for actions that link native artifacts,
including WebAssembly links with native dependencies. Retain mapping
for Rust libraries, metadata-only actions, ordinary documentation, and
WebAssembly links without native dependencies.
Use configuration-independent substitution tokens for generated-file
paths in compiler environment files. Resolve each token from its File
in the consuming action so shared environment files remain valid for
both mapped and unmapped layouts.
Assisted-by: Codex