Remove C Python headers from pyo3 build actions#4095
Open
Ahajha wants to merge 1 commit into
Open
Conversation
bazelbuild#4024 introduced a warning for targets adding CC deps in `deps`. The warning calls out putting this in `link_deps` or `cc_deps`. The latter makes more sense here... but doesn't actually exist. However, I don't think this matters anyways, as I don't think it's needed (this works with an internal codebase).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4024 introduced a warning for targets adding CC deps in
deps. The warning calls out putting this inlink_depsorcc_deps. The latter makes more sense here... but doesn't actually exist. However, I don't think this matters anyways, as I don't think it's needed (this works with an internal codebase).