Simplify Starlark prefix and suffix checks with tuples - #832
Open
dzbarsky wants to merge 4 commits into
Open
Conversation
dzbarsky
marked this pull request as ready for review
August 3, 2026 00:00
| has_legacy_link_shared_name = (_is_link_shared(ctx) and | ||
| (_matches([".so", ".dylib", ".dll", ".pyd"], target_name) or | ||
| cc_helper.is_valid_shared_library_name(target_name))) | ||
| has_legacy_link_shared_name = _is_link_shared(ctx) and cc_helper.is_valid_shared_library_name(target_name) |
Collaborator
There was a problem hiding this comment.
should this be an "or" instead? the _matches is redundant with is_valid_shared_library_name, but is_valid_shared_library_name should be sufficient even when not _is_link_shared
Contributor
Author
There was a problem hiding this comment.
Using or would change behavior for targets with shared-library filenames but linkshared = False. Not sure if we care but I erred toward making this a pure perf improvement to be safe
Collaborator
There was a problem hiding this comment.
you're right; I mis-read the parentheses.
lilygorsheneva
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starlark strings
startswithandendswith, like their Python counterparts, support batch checking against a tuple of possible endings. Use that capability instead of Starlark loops, since any reasonable implementation should be able to optimize this better.