Skip to content

feat: restore flag aliases to Starlark-defined flags #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregestren wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −19
Open

feat: restore flag aliases to Starlark-defined flags #3932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,25 +326,22 @@ uv_dev.configure(
version = "0.11.2",
)

# Temporarily comment out these flag aliases because they break Bazel 9
# when transitions are also used with a target.
#
# flag_alias(
# name = "build_python_zip",
# starlark_flag = "//python/config_settings:build_python_zip",
# )
flag_alias(
Comment thread
gregestren marked this conversation as resolved.
name = "build_python_zip",
starlark_flag = "//python/config_settings:build_python_zip",
)
Comment thread
rickeylev marked this conversation as resolved.

# flag_alias(
# name = "incompatible_default_to_explicit_init_py",
# starlark_flag = "//python/config_settings:incompatible_default_to_explicit_init_py",
# )
flag_alias(
name = "incompatible_default_to_explicit_init_py",
starlark_flag = "//python/config_settings:incompatible_default_to_explicit_init_py",
)

# flag_alias(
# name = "python_path",
# starlark_flag = "//python/config_settings:python_path",
# )
flag_alias(
name = "python_path",
starlark_flag = "//python/config_settings:python_path",
)

# flag_alias(
# name = "experimental_python_import_all_repositories",
# starlark_flag = "//python/config_settings:experimental_python_import_all_repositories",
# )
flag_alias(
name = "experimental_python_import_all_repositories",
starlark_flag = "//python/config_settings:experimental_python_import_all_repositories",
)