Skip to content

fix(build-data): remove CONFIG_MODE from build data #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
May 31, 2026
Merged

fix(build-data): remove CONFIG_MODE from build data #3801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ END_UNRELEASED_TEMPLATE

{#v0-0-0-removed}
### Removed
* (build_data) Removed CONFIG_MODE from build data
([#3793](https://github.com/bazel-contrib/rules_python/issues/3793)).
* (coverage) Support for python 3.8 has been dropped from the bundled
`coverage.py` wheel set, since coverage.py 7.6.2 dropped it.

Expand Down
1 change: 0 additions & 1 deletion python/private/build_data_writer.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
$OutputPath = $env:OUTPUT
$Lines = @(
"TARGET $env:TARGET",
"CONFIG_MODE $env:CONFIG_MODE",
"STAMPED $env:STAMPED"
)

Expand Down
1 change: 0 additions & 1 deletion python/private/build_data_writer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/bin/sh

echo "TARGET $TARGET" >> $OUTPUT
echo "CONFIG_MODE $CONFIG_MODE" >> $OUTPUT
echo "STAMPED $STAMPED" >> $OUTPUT
if [ -n "$VERSION_FILE" ]; then
cat "$VERSION_FILE" >> "$OUTPUT"
Expand Down
3 changes: 0 additions & 3 deletions python/private/py_executable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,9 +1578,6 @@ def _write_build_data(ctx):
executable = action_exe,
arguments = [action_args],
env = {
# Include config mode so that binaries can detect if they're
# being used as a build tool or not, allowing for runtime optimizations.
"CONFIG_MODE": "EXEC" if _is_tool_config(ctx) else "TARGET",
"INFO_FILE": info_file.path if info_file else "",
"OUTPUT": build_data.path,
# Include this so it's explicit, otherwise, one has to detect
Expand Down
2 changes: 0 additions & 2 deletions tests/build_data/build_data_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def test_target_build_data(self):
self.assertIn("BUILD_USER ", build_data)
self.assertIn("BUILD_TIMESTAMP ", build_data)
self.assertIn("FORMATTED_DATE ", build_data)
self.assertIn("CONFIG_MODE TARGET", build_data)
self.assertIn("STAMPED TRUE", build_data)

def test_tool_build_data(self):
Expand All @@ -25,7 +24,6 @@ def test_tool_build_data(self):
build_data = fp.read()

self.assertIn("STAMPED FALSE", build_data)
self.assertIn("CONFIG_MODE EXEC", build_data)


unittest.main()