tests: better simulate BCR environment#3706
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new script, .bazelci/isolate.sh, designed to simulate a Bazel Central Registry (BCR) environment by isolating a specific module directory and removing all other files in the repository root. The CI configuration in .bazelci/presubmit.yml has been updated to incorporate this isolation step for Gazelle and Sphinxdocs tasks. Feedback focuses on enhancing the script's reliability, specifically by handling trailing slashes in the input directory path and verifying the existence of the target directory before executing destructive file removals.
aignas
approved these changes
Apr 15, 2026
20ba0a5 to
b2d5a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better simulate the BCR environment by removing files that aren't
extracted when BCR extracts the release archive.