Skip to content

tests: better simulate BCR environment#3706

Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev:more.accurate.bcr.test
Apr 15, 2026
Merged

tests: better simulate BCR environment#3706
rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev:more.accurate.bcr.test

Conversation

@rickeylev
Copy link
Copy Markdown
Collaborator

Better simulate the BCR environment by removing files that aren't
extracted when BCR extracts the release archive.

@rickeylev rickeylev requested a review from aignas as a code owner April 14, 2026 23:43
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new script, .bazelci/isolate.sh, designed to simulate a Bazel Central Registry (BCR) environment by isolating a specific module directory and removing all other files in the repository root. The CI configuration in .bazelci/presubmit.yml has been updated to incorporate this isolation step for Gazelle and Sphinxdocs tasks. Feedback focuses on enhancing the script's reliability, specifically by handling trailing slashes in the input directory path and verifying the existence of the target directory before executing destructive file removals.

Comment thread .bazelci/isolate.sh Outdated
Comment thread .bazelci/isolate.sh Outdated
Comment thread .bazelci/isolate.sh
@rickeylev rickeylev force-pushed the more.accurate.bcr.test branch from 20ba0a5 to b2d5a52 Compare April 15, 2026 02:37
@rickeylev rickeylev added this pull request to the merge queue Apr 15, 2026
Merged via the queue into bazel-contrib:main with commit 7a68221 Apr 15, 2026
4 checks passed
@rickeylev rickeylev deleted the more.accurate.bcr.test branch April 15, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants