sphinxdocs: remove local rules_python dev overrides#3705
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Apr 15, 2026
Merged
sphinxdocs: remove local rules_python dev overrides#3705rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the local path override for the rules_python dependency in sphinxdocs/MODULE.bazel, which previously pointed to the parent directory. This change ensures that the project uses the specified version of rules_python (1.8.5) from the registry rather than a local development version. I have no feedback to provide as there are no review comments to evaluate.
aignas
approved these changes
Apr 14, 2026
rickeylev
force-pushed
the
sphinxdocs.no.rules.python.override
branch
from
5f4a64c to
d426fb7
Compare
rickeylev
added a commit
to rickeylev/rules_python
that referenced
this pull request
Apr 15, 2026
In the BCR integration test, the local override breaks on BCR itself because a local copy of rules_python isn't part of the test environment. Remove it from the sphinxdocs module, too, because it shouldn't be necessary. The two aren't that closely coupled. (cherry picked from commit c33ba23)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the BCR integration test, the local override breaks on BCR itself
because a local copy of rules_python isn't part of the test
environment.
Remove it from the sphinxdocs module, too, because it shouldn't
be necessary. The two aren't that closely coupled.