Repository navigation
ci(dependabot): removed the paths filter from the auto-merge caller - #9
Merged
Merged
Conversation
The caller only started for the two src Dockerfiles, so pip updates of
rabbitmq-init (requirements*.txt) never reached the auto-merge module:
no decision, no annotation, the PR just stayed open. Without the
filter every Dependabot PR is decided and annotated by the module.
Per ecosystem:
* docker (src/rabbitmq, src/rabbitmq-init) - unchanged, the PR run of
docker-release.yml builds both images
* pip (src/rabbitmq-init) - can now auto-merge: docker-release.yml
already runs on src/**, installs requirements-test.txt (which pulls
in requirements.txt), runs pytest and builds the rabbitmq-init image
* docker-compose - the compose files reference images only through
${VAR:-...}:${VAR:-latest}, which Dependabot cannot update; it has
opened no PR since June
* github-actions - still left open by the module's own .github/ guard
Not changed: required-workflows (docker-release.yml), the write
permissions (the repository is public, so the read scopes are not
needed), merge method, auto-approve and the module default of merging
patch updates only. docker-release.yml needs no wider paths: src/**
already covers every manifest Dependabot updates there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Dependabot auto-merge caller (
.github/workflows/docker-maintenance.yml) only started forsrc/rabbitmq/Dockerfileandsrc/rabbitmq-init/Dockerfile. A pip update of rabbitmq-init (requirements*.txt, e.g. #6) never reached the module: no decision, no annotation, the PR just stayed open. The module should react to every Dependabot ecosystem configured here and leave a visible decision on each PR.What
paths:filter from the caller'spull_requesttrigger (typesopened, synchronize, reopened, ready_for_reviewkept).docker-release.yml, which aGITHUB_TOKENmerge does not.Nothing else changed:
required-workflows: .github/workflows/docker-release.yml,merge-method: squash,auto-approve: true,secrets: inheritand the permissions all stay as they were. The repository is public, so the module does not need thechecks/statuses/actions: readscopes.docker-release.ymlneeds no widerpaths:: itspull_requesttrigger already coverssrc/**.dependabot.yml)/src/rabbitmq,/src/rabbitmq-initchore(docker)docker-release.ymlPR run builds both images (push: false) after compose and shell validation and the rabbitmq-init tests/src/rabbitmq-initchore(deps)docker-release.ymlruns onsrc/**.test-initinstallsrequirements-test.txt(which includes-r requirements.txt) and runs pytest.docker-build-init-prbuilds the image, whose Dockerfile COPYsrequirements.txtand installs from it/chore(deps)image:is${VAR:-...}:${VAR:-latest}, our own images and traefik-certs-dumper on floatinglatest. Dependabot cannot update these and has opened no compose PR since June/chore(ci).github/change openOnly patch updates are merged (the module default for
merge-update-types). Minor and major updates, such as #6 (pytest9.0.3 → 9.1.1, semver-minor), are left open with a notice. None of the prefixes cuts a release:choreproduces no semantic-release bump, and theGITHUB_TOKENmerge starts nopushrun.Compatibility
Test
pull_requestwith the four types and nopaths, and the permissions andwith:inputs are unchanged..github/, sodocker-release.ymldoes not run on it. Its CI shows the caller starting without a paths filter, with the maintenance job skipped because the PR is not from Dependabot.docker-release.yml, then merges a patch update or leaves a minor or major update open with a notice.