Skip to content

Fail fast on check runtime directory errors#935

Merged
codeforester merged 1 commit into
mainfrom
bug/910-20260622-check-runtime-dir
Jun 22, 2026
Merged

Fail fast on check runtime directory errors#935
codeforester merged 1 commit into
mainfrom
bug/910-20260622-check-runtime-dir

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • Treat empty JSON output from failed Python check/profile layers as fatal pre-output failures.
  • Preserve normal structured project/profile diagnostics when those layers return JSON with an error status.
  • Add a shell regression for runtime-dir failures that must emit only the concise Python error.

Validation

  • env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/check.bats --filter "basectl check project --format json fails fast on runtime directory errors"
  • env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/check.bats
  • env -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash ./bin/base-test
  • git diff --check

Fixes #910

@codeforester codeforester requested a review from a team as a code owner June 22, 2026 03:23
@codeforester codeforester merged commit 02e3622 into main Jun 22, 2026
18 checks passed
@codeforester codeforester deleted the bug/910-20260622-check-runtime-dir branch June 22, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make basectl check fail fast on Base runtime directory errors

1 participant