feat(runtime): migrate Base consumers to base-bash-libs v2 API - #1879
Closed
codeforester wants to merge 2 commits into
Closed
feat(runtime): migrate Base consumers to base-bash-libs v2 API#1879codeforester wants to merge 2 commits into
codeforester wants to merge 2 commits into
Conversation
Collaborator
Author
|
Superseded by policy-compliant PR for tracking issue #1880; implementation and basectl fix are unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_APIbasectl helpwork with the current v2 namespace and improve stale-library diagnosticsRoot cause
Base still called the removed
base_bash_libs_require_versionand other generic v1 symbols. The first failure masked a second issue: v2 stdlib state is explicit, so cleanup/file helpers needbase_initruntime initialization after sourcinglib_std.sh.Validation
bats tests/base_init.bats cli/bash/commands/basectl/tests/help.batsbats cli/bash/commands/basectl/tests/update-profile.batsBASE_BASH_LIBS_DIR=~/work/base-bash-libs/lib/bash ./bin/basectl helpBASE_BASH_LIBS_DIR=~/work/base-bash-libs/lib/bash ./bin/base-test(944 passed, 1 skipped in the Python suite)