Fix comment-typing freeze: scope drag-strum keydown + fix listener leak (#2926)

[vitalibondar]

Fixes #2926 — typing in a card's comment box freezes Safari (macOS + iOS) for 5–10s, worsening over a session.

drag_and_strum_controller adds a global keydown listener to play an instrument while a card is dragged between columns. Two problems make typing janky:

1. Listener leak (bind reference mismatch)

connect()    { document.addEventListener("keydown", this.handleKeyDown.bind(this)) }
disconnect() { document.removeEventListener("keydown", this.handleKeyDown.bind(this)) }

.bind(this) returns a new function each time, so removeEventListener never matches the listener added in connect. Every Turbo reconnect leaks another permanent global keydown listener; they accumulate over a session and all fire on each keystroke. This matches the reported "~15 keydown per typed character, worsens during a session".

Fix: bind once, store the reference, reuse it for add/remove.

2. Handler runs while typing

The handler fired on every document keydown, including inside the comment editor. Typing capital letters / shifted keys (event.shiftKey) repeatedly hit #preloadAudioFiles, constructing new Audio() in a loop on each keystroke. The strum is only meaningful during a drag, so keydown originating from a text field / contenteditable / the lexxy-editor is now ignored via a small #isEditingText guard (isContentEditable + closest("input, textarea, select, lexxy-editor")).

Notes

• The drag/strum easter-egg behaviour during an actual drag is unchanged.
• The repo has no JS controller test harness (no existing tests for this or sibling controllers), so this is a code-only change; node --check passes. The diagnosis and profiling are in Typing in comments freezes Safari: global keydown in drag_and_strum + heavy compositing #2926.

🤖 Generated with Claude Code

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Improves the controller’s global keyboard handling by making event listener cleanup reliable and preventing shortcuts from firing while the user is editing text.

Changes:

• Store a bound handleKeyDown reference to ensure removeEventListener unregisters correctly.
• Skip key handling when the event target is an editable/text input element.
• Add a private #isEditingText helper to centralize editability detection.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[vitalibondar]

Thanks — both points were fair, addressed in the latest commit:

1. Non-text inputs — #isEditingText no longer treats every <input> as text entry. It now skips button/submit/reset/checkbox/radio/file/image/range/color (via input.type), so the strum is only suppressed for actual text-entry fields, textarea, select, contenteditable, and lexxy-editor.
2. Target vs focus — added a document.activeElement fallback when the event has no target. The comment editor (lexxy-editor) is matched by tag, which also covers the Shadow DOM retargeting case (keydown/activeElement retarget to the host element), so the reported freeze stays fixed.