fix: use brews instead of homebrew_casks in goreleaser#124
Conversation
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
There was a problem hiding this comment.
Pull request overview
Updates the GoReleaser configuration to publish fizzy to the Homebrew tap as a standard Formula (not a Cask), so brew install basecamp/tap/fizzy resolves and installs correctly.
Changes:
- Replace
homebrew_caskswithbrewsand switch the tap output directory fromCasks/toFormula/. - Replace the cask-only
completions:shorthand with an explicitinstall:script that installs the binary and bash/zsh/fish completions. - Add a Homebrew
test:block that runsfizzy version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for working on this. The underlying issue is real: Homebrew install docs are currently ahead of what we publish. We’re not going to switch from The plan is:
|
Summary
homebrew_caskstobrewsCaskstoFormulacompletions:shorthand with an explicitinstall:block (including shell completions for bash, zsh, and fish)test:blockRoot cause
homebrew_casksis GoReleaser's DSL for macOS GUI apps distributed as.dmg/.pkginstallers.fizzyis a CLI binary in a tarball — it should usebrews, which generates a standard Homebrew Formula. The previous config was generating a Cask and writing it toCasks/in the tap, sobrew install basecamp/tap/fizzywas never resolvable.Verification
The generated formula in
dist/homebrew/Formula/fizzy.rb(produced bygoreleaser release --snapshot --clean) confirms correct output: platform-specificon_macos/on_linuxblocks, proper binary install, shell completions, and a passingtestblock.Fixes #107
Fixes #70
Summary by cubic
Fix Homebrew publishing for
fizzyby switching GoReleaser from casks to formulae. This makesbrew install basecamp/tap/fizzywork as expected.homebrew_caskswithbrewsto generate a Homebrew Formula for the CLI.Formula/instead ofCasks/.installblock to install the binary and completions (bash, zsh, fish).testblock that runsfizzy version.Written for commit 1410fc9. Summary will update on new commits.