Files feed: document parent for images hotlinked into chats - #426
Open
jeremy wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Documents how GET /files.json reports the parent recording for rich-text attachments when the attachment is an image hotlinked into a chat (where the parent is an autolinked-image wrapper rather than the surrounding document/message).
Changes:
- Clarifies that
parentidentifies the recording an attachment hangs from, which may be the containing doc/message or (for hotlinked chat images) an autolinked-image wrapper whoseurl/app_urlpoint at the chat line.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /files.jsonwraps rich-text attachments in a recording envelope whoseparentidentifies the recording the attachment hangs from. For most attachments that is the document or message they live in — but an image hotlinked into a chat is recorded under an autolinked-image wrapper, so that wrapper is theparent: itstitleis the image's source URL, and itsurlandapp_urlpoint at the surrounding chat line.This documents that case. (Requests for pages surfacing such attachments previously returned an error; they now render, with the parent shape described here.)
Synced from bc3
doc/api/byscript/api/sync_to_bc3_api— not a hand-edit.