docs(specs): challenger description mentions challenge as well as nullify#1590
Open
memosr wants to merge 1 commit into
Open
docs(specs): challenger description mentions challenge as well as nullify#1590memosr wants to merge 1 commit into
memosr wants to merge 1 commit into
Conversation
…lify The challenger.mdx frontmatter description said the challenger "submits dispute transactions on L1 to nullify them", but the spec body documents two distinct transaction types: - nullify() — referenced at lines 26 and 57 - challenge() — referenced at lines 148-149 The challenge() path is a first-class part of the challenger role, not a secondary action. Omitting it from the description misleads anyone reading the page header or navigating from a sidebar preview into thinking nullification is the only mechanism. Updated the description to mention both paths.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The challenger spec's frontmatter description omits the
challenge()transaction type — onlynullify()is mentioned. The spec body documents both as first-class actions.The drift
docs/base-chain/specs/protocol/proofs/challenger.mdx:3— frontmatter:Spec body, however, documents two distinct transactions the challenger submits:
nullify()— referenced at lines 26 and 57challenge()— referenced at lines 148–149These are not the same.
challenge()initiates a dispute against a proposed output;nullify()invalidates an already-finalized output. The challenger uses both depending on the attack scenario.Why this matters
The frontmatter description is what appears in:
Reading "submits dispute transactions on L1 to nullify them" leads someone scanning the docs to believe nullification is the sole mechanism. That's the most likely misconception people will form before clicking into the page — and it's wrong.
The fix
Single-line change. Matches what the spec body already documents.
Verification
docs/base-chain/specs/protocol/proofs/challenger.mdx