fix(docs): remove .mdx extension from signInWithEthereum link in wallet_connect reference#1312
Open
ygd58 wants to merge 1 commit intobase:masterfrom
Open
fix(docs): remove .mdx extension from signInWithEthereum link in wallet_connect reference#1312ygd58 wants to merge 1 commit intobase:masterfrom
ygd58 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
…et_connect reference
ygd58
force-pushed
the
fix/remove-mdx-extension-signInWithEthereum
branch
from
e67e5db to
7280f25
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was looking at the wallet connect reference page and noticed the signInWithEthereum capability link was broken. The link had a .mdx extension at the end which Mintlify does not handle as a valid path so it returns 404. Removed the extension and the link works fine now. The file itself exists at docs/base account/reference/core/capabilities/signInWithEthereum.mdx but the URL should not include the extension. Single line change on line 193 of wallet connect.mdx.