Propose composite policy interface (UNION/INTERSECT) by rayyan224 · Pull Request #174 · base/base-std

rayyan224 · 2026-07-22T21:48:50Z

Proposal (interface-only)

Adds the composite-policy surface to IPolicyRegistry as a design proposal. This PR changes only the interface — no MockPolicyRegistry or Rust precompile implementation — so the mock will not compile against it until a follow-up lands. Opened as a draft for design review.

What changes

PolicyType gains UNION and INTERSECT. Append-only: leaf discriminants (BLOCKLIST=0, ALLOWLIST=1) are unchanged, and the gate rides the policy ID top byte, so composites need no separate type storage.
createCompositePolicy(address admin, PolicyType gate, uint64[] operands) — creates a UNION/INTERSECT over existing flat leaf policies (never other composites). Operands reference smaller, already-assigned IDs, so the reference graph is a DAG and cannot cycle.
updateCompositeOperands(uint64 policyId, uint64[] operands) — replace-all: overwrites the whole operand set, re-validated exactly as at creation. The gate is fixed in the ID and cannot change.
Events: CompositePolicyCreated, CompositeOperandsUpdated (carries the full post-update set for single-log indexing).
Errors: EmptyOperandSet, InvalidOperand(operandId).
NatSpec on createPolicy / createPolicyWithAccounts now notes they revert IncompatiblePolicyType for composite gates.

Why replace-all for update

Operands live in a uint64[] (evaluation folds them in order). The registry has no uint64[]-mutation code today, so incremental add/remove would introduce the module's first swap-remove + length + dedup path. With the operand set capped small, sending the full list is the simpler design and reuses create's validation. Mirrors the IB20.updatePolicy full-replace precedent over the updateAllowlist incremental one.

Open question for reviewers

The CompositeOperandsUpdated event carries new operands only. A design council flagged an old → new shape (matching updatePolicy) as an option that closes a silent lost-update detection gap, at the cost of one warm SLOAD. Event surface is frozen at the fork, so this is worth settling before implementation.

Follow-ups (not in this PR)

MockPolicyRegistry implementation + test/unit/PolicyRegistry/ tests (create, update, revert-order, fold truth tables).
Rust precompile V2 (versioned, new fork), composite_operands storage slot, dispatcher wiring.

Generated with Claude Code

Interface-only proposal for composite policies on IPolicyRegistry: - Extend PolicyType with UNION and INTERSECT (append-only; leaf discriminants 0/1 unchanged, gate rides the policy ID top byte). - Add createCompositePolicy(admin, gate, operands) and updateCompositeOperands(policyId, operands). Update is a full-set overwrite (replace-all), re-validated as at creation. - Add CompositePolicyCreated and CompositeOperandsUpdated events, and EmptyOperandSet / InvalidOperand errors. - Note on createPolicy/createPolicyWithAccounts that composite gates revert IncompatiblePolicyType. Operands are flat-only (leaf ALLOWLIST/BLOCKLIST), capped at the composite operand limit, and the set may not be empty. This changes only the interface; MockPolicyRegistry and the Rust precompile implementation follow in a separate PR, so the mock will not compile against this interface until then. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>

github-actions · 2026-07-22T21:49:17Z

Interface Coverage

❌ Interface functions with no test coverage found.

Warning: Found unknown `base` config for profile `fork` defined in foundry.toml.
Warning: optimizer settings and `viaIR` have been disabled for accurate coverage reports.
If you encounter "stack too deep" errors, consider using `--ir-minimum` which enables `viaIR` with minimum optimization resolving most of the errors.
See more: https://book.getfoundry.sh/guides/best-practices/stack-too-deep
Error: Compiler run failed:
Error (3656): Contract "MockPolicyRegistry" should be marked as abstract.
  --> test/lib/mocks/MockPolicyRegistry.sol:57:1:
   |
57 | contract MockPolicyRegistry is IPolicyRegistry {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> src/interfaces/IPolicyRegistry.sol:142:5:
    |
142 |     function createCompositePolicy(address admin, PolicyType policyType, uint64[] calldata childPolicyIds)
    |     ^ (Relevant source part starts here and spans across multiple lines).
Note: Missing implementation: 
   --> src/interfaces/IPolicyRegistry.sol:216:5:
    |
216 |     function updateComposite(uint64 policyId, uint64[] calldata childPolicyIds) external;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning (1699): "selfdestruct" has been deprecated. Note that, starting from the Cancun hard fork, the underlying opcode no longer deletes the code and data associated with an account and only transfers its Ether to the beneficiary, unless executed in the same transaction in which the contract was created (see EIP-6780). Any use in newly deployed contracts is strongly discouraged even if the new behavior is taken into account. Future changes to the EVM might further reduce the functionality of the opcode.
  --> test/lib/ForceFeeder.sol:20:13:
   |
20 |             selfdestruct(target)
   |             ^^^^^^^^^^^^\n```

github-actions · 2026-07-22T21:52:25Z

❌ Fork tests did not run

The build or setup step failed before any tests could execute. Check the workflow logs for details.

rayyan224 · 2026-07-22T21:57:01Z

    function createPolicy(address admin, PolicyType policyType) external returns (uint64 newPolicyId);

-    /// @notice Creates a new policy seeded with `accounts` as initial members. Permissionless.
+    /// @notice Creates a new leaf policy seeded with `accounts` as initial members. Permissionless.


Remove leaf here

Drop the "not an incremental edit" binary contrast and the "silently" adverb; make the flat-only note active. Wording only, no signature or behavior change. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>

ilikesymmetry · 2026-07-22T22:35:37Z


+    /// @notice A composite policy (UNION or INTERSECT) was created over `operands`.
+    event CompositePolicyCreated(
+        uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] operands


feel like I want to see the clarification of "policy" in there

Suggested change

uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] operands

uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] operandPolicies

Do we even need this event? Why not just use PolicyCreated as-is and then combine with the event below for declaring operand policies updated?

I think we can use policy created. Only thing is I would assume a user want's an event that lists the new childPolicyIds for the composite, when a policy is created / updated.

The existing PolicyCreated event does declare the policy type so I think your goal is met as-is

But it wouldn't solve the event that the user can see the new childPoloicyId's

Updated to PolicyCreated, and a UpdateCompositePolicyEvent both being emitted

Co-authored-by: katzman <steve.katzman@coinbase.com>

Co-authored-by: Conner Swenberg <conner.swenberg@coinbase.com>

Co-authored-by: katzman <steve.katzman@coinbase.com>

Co-authored-by: Conner Swenberg <conner.swenberg@coinbase.com>

ilikesymmetry · 2026-07-23T17:07:16Z

+    /// @notice A composite policy (UNION or INTERSECT) was created over `childPolicyIds`.
+    event CompositePolicyCreated(
+        uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] childPolicyIds
+    );


Seems to ignore discussion here: #174 (comment).

As we keep adding policy types with more nuance, we'll continually run up against the desire to have custom created events that have all of the content of PolicyCreated, but with a new field(s). I think we should take the opinionated stance that we have one canonical creation event (PolicyCreated) and we use *Updated events for the type-specific field(s). This gives indexers the cleanest experience where this is only one path for creation to look at ever and only one path for field updates to look at (regardless of creation/update).

Suggested change

/// @notice A composite policy (UNION or INTERSECT) was created over `childPolicyIds`.

event CompositePolicyCreated(

uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] childPolicyIds

);

So the create function fires two events fires two events, Created and UpdatePolicy ?

Use the canonical PolicyCreated event for every policy type and surface composite child policies via CompositePolicyUpdated (now emitted on both creation and update). Gives indexers one creation path and one per-field update path. Addresses PR #174 review. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>

stevieraykatz · 2026-07-23T20:15:18Z

+    /// @param provided Number of child policy IDs supplied.
+    /// @param minimum  Minimum required (2).
+    error TooFewChildPolicies(uint256 provided, uint256 minimum);


I don't think this error needs params. The natspec says you need at least two and the user will know how many they provided.

Is there any, downside of having it ?

gas if a reverting tx ever lands onchain

stevieraykatz · 2026-07-23T20:24:35Z

+    /// @dev Reverts with `PolicyNotFound` when any child policy does not exist.
+    /// @dev Reverts with `InvalidChildPolicy` when any child policy is itself a composite
+    ///      (not a simple policy).
+    /// @dev Panics with arithmetic overflow (Panic 0x11) when the policy counter has reached its maximum value.


Aren't we going to explicitly check that 2 < childPolicyIds <= 4? What risk is there of overflow?

They share the create counter which can overflow

oooh for the global policy id. i don't think this needs explicit callout here...

Co-authored-by: katzman <steve.katzman@coinbase.com>

…com/base/base-std into composite-policy-interface-proposal

rayyan224 commented Jul 22, 2026

View reviewed changes

Tighten composite NatSpec wording

e685897

Drop the "not an incremental edit" binary contrast and the "silently" adverb; make the flat-only note active. Wording only, no signature or behavior change. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>

ilikesymmetry reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

ilikesymmetry reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

ilikesymmetry reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 22, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

rayyan224 and others added 8 commits July 23, 2026 10:08

Apply suggestion from @stevieraykatz

0c29a7e

Co-authored-by: katzman <steve.katzman@coinbase.com>

Apply suggestion from @ilikesymmetry

5c14492

Co-authored-by: Conner Swenberg <conner.swenberg@coinbase.com>

Apply suggestion from @stevieraykatz

0f599ad

Co-authored-by: katzman <steve.katzman@coinbase.com>

Apply suggestion from @ilikesymmetry

57e6caa

Co-authored-by: Conner Swenberg <conner.swenberg@coinbase.com>

feat: poloicy registry

2594d62

feaet: more clean up

6f30915

chore: clean up

bc683b1

feat: rename to simple

35e816a

rayyan224 requested review from ilikesymmetry and stevieraykatz July 23, 2026 17:10

chore: clean up

fe6710a

ilikesymmetry requested changes Jul 23, 2026

View reviewed changes

ilikesymmetry reviewed Jul 23, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

rayyan224 and others added 3 commits July 23, 2026 15:24

chore: update error types

0682ec3

feat: update policy registry

050a4b0

rayyan224 requested a review from ilikesymmetry July 23, 2026 19:41

chore: update dev docs

4d27af7

stevieraykatz reviewed Jul 23, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 23, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 23, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol

stevieraykatz reviewed Jul 23, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

stevieraykatz reviewed Jul 23, 2026

View reviewed changes

Comment thread src/interfaces/IPolicyRegistry.sol Outdated

rayyan224 and others added 6 commits July 23, 2026 16:28

Apply suggestion from @stevieraykatz

2bd24c2

Co-authored-by: katzman <steve.katzman@coinbase.com>

Apply suggestion from @stevieraykatz

03230f2

Co-authored-by: katzman <steve.katzman@coinbase.com>

Apply suggestion from @stevieraykatz

500e269

Co-authored-by: katzman <steve.katzman@coinbase.com>

Apply suggestion from @stevieraykatz

14c9bb5

Co-authored-by: katzman <steve.katzman@coinbase.com>

feat: policy registry

aa0dc53

Merge branch 'composite-policy-interface-proposal' of https://github.…

ffc3105

…com/base/base-std into composite-policy-interface-proposal

rayyan224 requested a review from stevieraykatz July 23, 2026 20:37

chore: clean up

fb594b2

	uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] operands
	uint64 indexed policyId, address indexed creator, PolicyType policyType, uint64[] operandPolicies

Uh oh!

Conversation

rayyan224 commented Jul 22, 2026

Proposal (interface-only)

What changes

Why replace-all for update

Open question for reviewers

Follow-ups (not in this PR)

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Interface Coverage

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Fork tests did not run

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rayyan224 Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rayyan224 Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

rayyan224 Jul 23, 2026 •

edited

Loading

rayyan224 Jul 23, 2026 •

edited

Loading