Bugfix/codechecker analysis fixes - #80
Merged
Merged
Conversation
…for Zephyr macros
There was a problem hiding this comment.
Pull request overview
This pull request focuses on addressing static-analysis/code-checker findings across the Zephyr BACnet integration by tightening error handling, fixing type/format mismatches, and adjusting CodeChecker configuration and test build inputs.
Changes:
- Update BACnet shell and settings/storage code to reduce warnings (unused args, return-value handling, signed/unsigned conversions).
- Fix and clarify BACnet settings/storage key handling and shell utilities (decode/encode error paths, JSON/hex helpers, argument parsing).
- Adjust CodeChecker configuration (skip rules and disabled diagnostics) and include an additional BACnet source file in the unit test build.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zephyr/tests/bacnet/basic/object/acc/CMakeLists.txt | Adds cov.c to unit test sources to satisfy link/analysis dependencies. |
| zephyr/subsys/bacnet_shell/bacnet_shell_property.c | Adds early error returns and various type/return-value adjustments to satisfy analyzers. |
| zephyr/subsys/bacnet_shell/bacnet_shell_objects.c | Aligns count type/printf formatting. |
| zephyr/subsys/bacnet_shell/bacnet_shell_lighting_output.c | Fixes formatting/typing and makes status strings explicit. |
| zephyr/subsys/bacnet_settings/bacnet_storage.c | Improves error handling and types around settings load/store operations. |
| zephyr/subsys/bacnet_settings/bacnet_storage_shell.c | Improves encode error handling and string formatting checks; marks unused args. |
| zephyr/subsys/bacnet_settings/bacnet_settings.c | Adds object-parse API and tightens parsing/size casts. |
| zephyr/subsys/bacnet_settings/bacnet_settings_shell.c | Improves encode/decode error handling and string formatting checks; marks unused args. |
| zephyr/subsys/bacnet_datalink/bip-init.c | Adds unused-arg markers and small type/logic tweaks in timeout/interface handling. |
| zephyr/include/bacnet_settings/bacnet_settings.h | Exposes bacnet_settings_object_parse() in the public header. |
| codechecker/skip.txt | Updates CodeChecker skip/include patterns. |
| codechecker/.codechecker.yml | Disables select diagnostics that conflict with common Zephyr patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.