topology - version:bump to v1.54.5

[debsmita1]

Hey, I just made a Pull Request!

Version upgrade to 1.54.5

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@internal/plugin-topology-dev-backend	workspaces/topology/plugins/topology-dev-backend	none	v0.0.0
@backstage-community/plugin-topology	workspaces/topology/plugins/topology	minor	v2.16.3

[teknaS47]

All tests passing
/lgtm

[ciiay]

Thanks for the bump and the NFS layout/e2e follow-ups — CI looks good.

Please take a look (not nits):

• The calc(100vh - 16rem) height on .pf-ri__topology applies to legacy as well as NFS, and 16rem is a magic number that will drift with header/banner changes.
• The GitHub auth backend module is added without matching auth.providers.github config.

Nits are marked nit on the inline comments (target 1.54.5, unused bs-topology-view class, English-only tab locator). None of those are merge blockers.

nit (PR description): the body only says “Version upgrade to 1.54.0”, but the real extra work is the NFS height fix and e2e locator updates — worth a sentence so reviewers don’t miss it.

[teknaS47]

Tried running the tests, was getting this error even for yarn start

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.42%. Comparing base (99a88ab) to head (eef5b05).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10359      +/-   ##
==========================================
- Coverage   75.42%   75.42%   -0.01%     
==========================================
  Files         731      732       +1     
  Lines       18439    18442       +3     
  Branches     4443     4458      +15     
==========================================
+ Hits        13907    13909       +2     
  Misses       4479     4479              
- Partials       53       54       +1     

Flag	Coverage Δ		*Carryforward flag
acr	77.35% <ø> (ø)		Carriedforward from 99a88ab
argocd	94.02% <ø> (ø)		Carriedforward from 99a88ab
jfrog-artifactory	45.00% <ø> (ø)		Carriedforward from 99a88ab
nexus-repository-manager	35.47% <ø> (ø)		Carriedforward from 99a88ab
npm	5.97% <ø> (ø)		Carriedforward from 99a88ab
ocm	78.26% <ø> (ø)		Carriedforward from 99a88ab
pingidentity	93.54% <ø> (ø)		Carriedforward from 99a88ab
quay	90.70% <ø> (ø)		Carriedforward from 99a88ab
rbac	81.35% <ø> (ø)		Carriedforward from 99a88ab
scaffolder-backend-module-annotator	97.60% <ø> (ø)		Carriedforward from 99a88ab
scaffolder-backend-module-kubernetes	100.00% <ø> (ø)		Carriedforward from 99a88ab
scaffolder-backend-module-regex	100.00% <ø> (ø)		Carriedforward from 99a88ab
scaffolder-backend-module-servicenow	80.43% <ø> (ø)		Carriedforward from 99a88ab
scaffolder-backend-module-sonarqube	100.00% <ø> (ø)		Carriedforward from 99a88ab
servicenow	81.66% <ø> (ø)		Carriedforward from 99a88ab
tekton	78.69% <ø> (ø)		Carriedforward from 99a88ab
topology	64.10% <66.66%> (+<0.01%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a88ab...eef5b05. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ciiay]

/lgtm

Thanks for following up. The earlier comments are addressed:

• NFS height uses FullPage (TopologyEntityContent) instead of calc(100vh - 16rem), so legacy keeps height: 100%
• GitHub auth module / SignInPage GitHub provider removed
• Bump is 1.54.5
• Tab locator uses href$="/topology"
• Guest SignInPage on the NFS mock app, and e2e is green on Node 22/24

Non-blocking leftovers: unused permission.rbac in app-config.yaml, and the TopologyEntityContent unit test still has a ?? topology.parentElement fallback. Fine to land as-is.