fix(opencode): preserve planning handoff#1034
Open
franktronics wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the OpenCode
planagent and configured planning agents from receiving theProceed with implementationhandoff after plan approval.Keep the implementation handoff unchanged for
buildand other non-planning agents.Emit a visible status message when approval targets a planning agent:
Plan approved. Plan mode remains active; no implementation has been requested.Related issues
Regression from #648: the agent picker correctly removed the implementation directive for
No switch, but selectingplanstill injectedProceed with implementation.#648 also addressed #159, which requested approval without automatically starting implementation. This change preserves that behavior when the selected target is a planning agent.
Changes
apps/opencode-plugin/workflow.tsapps/opencode-plugin/index.tsapps/opencode-plugin/workflow.test.tsbuild,plan, custom planning agents, and regular non-planning agents.Test plan
bun test apps/opencode-pluginbun run build:opencodeplankeeps plan mode active and displays the status message.buildstill sendsProceed with implementation.