Update error message on ModelBuilder when deploying from S3 checkpoint - #6111
Merged
zhaoqizqwang merged 3 commits intoJul 28, 2026
Merged
Conversation
mujtaba1747
reviewed
Jul 27, 2026
| # Validate required fields that would normally be auto-resolved. | ||
| missing_fields = [] | ||
| if not self.image_uri: | ||
| missing_fields.append("image_uri") |
Collaborator
There was a problem hiding this comment.
do we need the image uri for OSS serverful SMTJ as well?
Collaborator
Author
There was a problem hiding this comment.
This would apply to both Nova and non-Nova models. I have updated the code in new commit to find image_uri from Hub based using base_model_name
| ) | ||
|
|
||
| # If user already provided image_uri, skip hub resolution | ||
| if self.image_uri: |
Contributor
There was a problem hiding this comment.
This should go before base_model_name. If the user already has an image uri, they do not need a base_model_name for resolution.
Collaborator
Author
There was a problem hiding this comment.
base_model_name validation is still required. I just moved it out of this util function
| hub_content_name = model_package.inference_specification.containers[0].base_model.hub_content_name | ||
| else: | ||
| # No model package (e.g. SMTJ trainer): resolve from base_model_name | ||
| from sagemaker.train.common_utils.model_aliases import normalize_model_name |
Contributor
There was a problem hiding this comment.
This could be a top level import
amazeAmazing
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update error message on ModelBuilder when deploying from S3 checkpoint
ModelTrainer.train()image_uri,base_job_namein ModelBuilder