[DO NOT MERGE] test: verify Codecov config takes effect (same-repo) - #6055
Closed
jam-jee wants to merge 1 commit into
Closed
[DO NOT MERGE] test: verify Codecov config takes effect (same-repo)#6055jam-jee wants to merge 1 commit into
jam-jee wants to merge 1 commit into
Conversation
No-op docstring line in sagemaker.mlops to force a unit-test coverage upload from a SAME-REPO branch (fork PRs upload without PR/branch context and Codecov errors them). Confirms the merged codecov.yml takes effect: - test files excluded from the report (ignore: list) - product-only project coverage (~71%, not the old test-inflated ~90%) - project floor 65% / patch 70% status targets Branch cut from current master (contains codecov.yml). Verification only.
This was referenced Jul 18, 2026
jam-jee
added a commit
that referenced
this pull request
Jul 27, 2026
…erage (#6056) `after_n_builds: 4` made Codecov wait for four coverage uploads before finalizing a report. But this repo's CI runs unit tests only for the submodules a PR changes (detect-changes), so a PR touching 1-3 submodules produces fewer than four uploads. Codecov then waits forever and never posts a report or status. Observed on PR #6055 (changed only sagemaker-mlops): the mlops unit-test job uploaded coverage successfully, but Codecov reported state=error, sessions=0 and posted no codecov/project or codecov/patch status, because it was still waiting for three more uploads that never come. Drop the fixed count and rely on `wait_for_ci: true`, which finalizes the report once CI completes using whatever uploaded — correct for this repo's dynamic per-submodule CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirms the merged
codecov.yml(PR #6034) takes effect. Makes a no-op docstring-only change insagemaker.mlopsto force a unit-test coverage upload so Codecov recomputes.Why same-repo (not a fork): the earlier fork-based attempt (#6054) uploaded coverage but Codecov errored it (
state=error, sessions=0) because the CodeBuild uploader gets no PR/branch context for fork PRs (pr=false, empty branch). Same-repo branches upload with full context (verified: #6051 processed cleanly withsessions=4), so Codecov will actually process and post here.This branch is cut from current master (which contains
codecov.yml). Expected result:ignore:(previously ~98% of measured files were test files)Will be closed without merging once verified.